feat(sid): Allow duplicate SID identifiers when doing initial altitudes #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AxonC
approved these changes
Jan 19, 2022
VATSIMUK
pushed a commit
that referenced
this pull request
Jan 21, 2022
|
🎉 This PR is included in version 3.14.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 4.0.0-beta.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
AndyTWF
added a commit
that referenced
this pull request
Jan 23, 2022
* feat(missedapproach): Allow airfields to always alert regardless of service provision (#384) * Update static test * Audio alert conditions * Render when relevant * Docs update * feat(misssedapproach): Allow airfields to always alert regardless of service provision BREAKING CHANGE: The airfield selector for Missed Approach configuration now acts as an override to the service provision options, rather than a filter for which airfields to use. * Semantic release for beta * Remove modifier * Dump semantic release * Branch detect * chore(release): 4.0.0-beta.1 [skip ci] # [4.0.0-beta.1](3.13.1...4.0.0-beta.1) (2022-01-05) ### Features * **missedapproach:** Allow airfields to always alert regardless of service provision ([#384](#384)) ([5fe9fd7](5fe9fd7)) * **misssedapproach:** Allow airfields to always alert regardless of service provision ([4398182](4398182)) ### BREAKING CHANGES * **misssedapproach:** The airfield selector for Missed Approach configuration now acts as an override to the service provision options, rather than a filter for which airfields to use. * feat(departure): Combine pending prenotes and releases into one list (#386) * Create new list from releases list * Add type column * Add toggle * Bootstrap new toggles * Start prenotes mixin * Display Prenotes Properly * Fix bugs * Test updates * Docs * Remove old code * Style * Fix test * Fix another test * One last test fix * Fix created at time on release * feat(departure): Combine pending prenotes and departure releases lists into one BREAKING CHANGE: The old lists are replaced by a single list. New ASR settings are also used for this list. * chore(release): 4.0.0-beta.2 [skip ci] # [4.0.0-beta.2](4.0.0-beta.1...4.0.0-beta.2) (2022-01-05) ### Features * **departure:** Combine pending prenotes and departure releases lists into one ([91c0614](91c0614)) * **departure:** Combine pending prenotes and releases into one list ([#386](#386)) ([531b687](531b687)) ### BREAKING CHANGES * **departure:** The old lists are replaced by a single list. New ASR settings are also used for this list. * fix(updater): Handle empty binaries during updates (#388) * Handle empty responses * Rejig updates * Style * chore(release): 4.0.0-beta.3 [skip ci] # [4.0.0-beta.3](4.0.0-beta.2...4.0.0-beta.3) (2022-01-08) ### Bug Fixes * **updater:** Handle empty binaries during updates ([#388](#388)) ([dc988b0](dc988b0)) * chore(release): 4.0.0-beta.4 [skip ci] # [4.0.0-beta.4](4.0.0-beta.3...4.0.0-beta.4) (2022-01-11) ### Bug Fixes * **metars:** metars not updating when they should ([#396](#396)) ([4048974](4048974)), closes [#395](#395) * **push-events:** data not synchronising on second instance startup ([#400](#400)) ([7953627](7953627)), closes [#399](#399) * **push-events:** Push events not proxying to second EuroScope instance ([#398](#398)) ([e1920fd](e1920fd)), closes [#397](#397) * chore(release): 4.0.0-beta.5 [skip ci] # [4.0.0-beta.5](4.0.0-beta.4...4.0.0-beta.5) (2022-01-17) ### Bug Fixes * **intentioncode:** add GOREV as exit fix for K2 intention code ([#406](#406)) ([4135248](4135248)) * chore(release): 4.0.0-beta.6 [skip ci] # [4.0.0-beta.6](4.0.0-beta.5...4.0.0-beta.6) (2022-01-20) ### Bug Fixes * **handoffs:** Handoffs not repopulating when controllers log on ([#413](#413)) ([d1d872e](d1d872e)), closes [#412](#412) * **pressuremonitor:** Trigger pressure monitor updates correctly ([#411](#411)) ([287d395](287d395)), closes [#409](#409) * chore(release): 4.0.0-beta.7 [skip ci] # [4.0.0-beta.7](4.0.0-beta.6...4.0.0-beta.7) (2022-01-23) ### Features * **holds:** Hold Manager UX Improvements ([#404](#404)) ([c0c999b](c0c999b)) * **sid:** Allow duplicate SID identifiers when doing initial altitudes ([#402](#402)) ([6aeacfc](6aeacfc)) Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
VATSIMUK
pushed a commit
that referenced
this pull request
Jan 23, 2022
# [4.0.0](3.14.0...4.0.0) (2022-01-23) * 4.0.0 release (#407) ([3503511](3503511)), closes [#407](#407) [#384](#384) [#384](#384) [#386](#386) [#386](#386) [#388](#388) [#388](#388) [#395](#395) [#399](#399) [#397](#397) [#406](#406) [#412](#412) [#409](#409) [#404](#404) [#402](#402) ### BREAKING CHANGES * The airfield selector for Missed Approach configuration now acts as an override to the service provision options, rather than a filter for which airfields to use. * Semantic release for beta * Remove modifier * Dump semantic release * Branch detect * chore(release): 4.0.0-beta.1 [skip ci] # [4.0.0-beta.1](3.13.1...4.0.0-beta.1) (2022-01-05) ### Features * The old lists are replaced by a single list. New ASR settings are also used for this list. * chore(release): 4.0.0-beta.2 [skip ci] # [4.0.0-beta.2](4.0.0-beta.1...4.0.0-beta.2) (2022-01-05) ### Features * **departure:** Combine pending prenotes and departure releases lists into one ([91c0614](91c0614))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the sectorfile team have to declare some SIDs with unique identifiers where they would normally have the same identifier but different parameters so the plugin can tell them apart for initial altitudes. The plugin matches SIDs by airfield and identifier.
This changes the SID matching algorithm to take runways into account.
Resolves #401