Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wake): Add not applicable to wake calculator display #426

Merged
merged 2 commits into from Feb 10, 2022

Conversation

AndyTWF
Copy link
Contributor

@AndyTWF AndyTWF commented Feb 8, 2022

It was sometimes hard to tell when there wasn't a wake interval because
it couldn't be worked out (or because of a bug) and when there legitimately isn't one.
This makes the default display to be a double dash. If two aircraft are selected such that
no interval applies (e.g. LM followed by LM), it will instead display N/A which makes it clear
to the user that there is no applicable interval.

Resolves #425

It was sometimes hard to tell when there wasn't a wake interval because
it couldn't be worked out (or because of a bug) and when there legitimately isn't one.
This makes the default display to be a double dash. If two aircraft are selected such that
no interval applies (e.g. LM followed by LM), it will instead display N/A which makes it clear
to the user that there is no applicable interval.

Resolves VATSIM-UK#425
@AndyTWF AndyTWF requested a review from AxonC February 8, 2022 20:52
@AndyTWF AndyTWF merged commit 6ec1b87 into VATSIM-UK:main Feb 10, 2022
VATSIMUK pushed a commit that referenced this pull request Feb 10, 2022
# [4.2.0](4.1.1...4.2.0) (2022-02-10)

### Features

* **pressure:** Make pressure monitor message more brief ([#424](#424)) ([058be53](058be53)), closes [#423](#423)
* **wake:** Add not applicable to wake calculator display ([#426](#426)) ([6ec1b87](6ec1b87)), closes [#425](#425)
@VATSIMUK
Copy link

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change No Applicable Departure Interval Text
3 participants