You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What first came to my mind is that loading the image could be abstracted away through an interface, so that client code can use whatever technique it wants (popular libraries like Picasso, Glide, Universal Image Loader, Fresco, etc.) instead of directly loading a Bitmap.
So rather than using addImage(Bitmap image), it would be addImage(ScrollGalleryViewItem item), where:
Also, there would be a default implementation of this interface SimpleScrollGalleryViewItem, which simply does what the lib currently does, so that people can easily use the lib without any extra code right away.
What do you think?
Ps.: 👍 for the nice, clean code :)
The text was updated successfully, but these errors were encountered:
Hello there, great lib!
What first came to my mind is that loading the image could be abstracted away through an interface, so that client code can use whatever technique it wants (popular libraries like Picasso, Glide, Universal Image Loader, Fresco, etc.) instead of directly loading a Bitmap.
So rather than using
addImage(Bitmap image)
, it would beaddImage(ScrollGalleryViewItem item)
, where:(Just a rough sketch, but you get the idea)
Also, there would be a default implementation of this interface
SimpleScrollGalleryViewItem
, which simply does what the lib currently does, so that people can easily use the lib without any extra code right away.What do you think?
Ps.: 👍 for the nice, clean code :)
The text was updated successfully, but these errors were encountered: