Add getCurrentItem method to ScrollGalleryView #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest version of the change. I've just added
getCurrentItem()
that exposes the same method fromViewPager
.I just noticed that you've added a
getViewPager()
method where you can get the whole ViewPager object. Maybe this could lead to bad usages from library users, such as changing the adapter and breaking up the whole thing.Anyway, if you want to include this method in the next version, I think it could be useful :) I wait for the next release to have some issues like #27 or #32 fixed.
I've also had a look at #43. I think it is related to this code:
I've just discovered that
setCurrentItem
can be called before initializing the ViewPager, so it causesNullPointerException
. A workaround could be calling.setCurrentItem
after.setFragmentManager
. I'll update my comment in #43.