Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getCurrentItem method to ScrollGalleryView #45

Merged
merged 1 commit into from Feb 20, 2017
Merged

Add getCurrentItem method to ScrollGalleryView #45

merged 1 commit into from Feb 20, 2017

Conversation

voghDev
Copy link
Contributor

@voghDev voghDev commented Feb 16, 2017

This is the simplest version of the change. I've just added getCurrentItem() that exposes the same method from ViewPager.

I just noticed that you've added a getViewPager() method where you can get the whole ViewPager object. Maybe this could lead to bad usages from library users, such as changing the adapter and breaking up the whole thing.

Anyway, if you want to include this method in the next version, I think it could be useful :) I wait for the next release to have some issues like #27 or #32 fixed.

I've also had a look at #43. I think it is related to this code:

public ScrollGalleryView setCurrentItem(int i) {
    viewPager.setCurrentItem(i, false);
    return this;
}

I've just discovered that setCurrentItem can be called before initializing the ViewPager, so it causes NullPointerException. A workaround could be calling .setCurrentItem after .setFragmentManager. I'll update my comment in #43.

@VEINHORN VEINHORN merged commit c9febb3 into VEINHORN:master Feb 20, 2017
@VEINHORN
Copy link
Owner

@voghDev thank you. 👌

@voghDev
Copy link
Contributor Author

voghDev commented Feb 21, 2017

You're welcome :) are you planning to release a new version of the library with the most recent changes?

@VEINHORN
Copy link
Owner

VEINHORN commented Feb 6, 2018

1.0.7 is available for now. 1.0.8 is coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants