Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbio: too many "sample ID" terms #46

Closed
danicahelb opened this issue Dec 8, 2022 · 2 comments
Closed

mbio: too many "sample ID" terms #46

danicahelb opened this issue Dec 8, 2022 · 2 comments
Assignees

Comments

@danicahelb
Copy link

I'm looking at the 2 mbio MALED studies and there are way too many sample ID terms!

Example: MALED 2yr study has the following sample IDs:
Sample ID (key identifier)
Sample ID (which is in a different format from the key identifier)
ClinEpiDB Sample ID
SRA Sample ID

In ticket #47, I requested that the data loaders use the same format for key identifiers in ClinEpi & mbio. After this is complete, we will be able to remove "ClinEpiDB sample ID"

Check in with @dpbisme about whether we need to load Sample ID and SRA Sample ID. If we want to keep both, we will need a more descriptive label for the "Sample ID" variable to distinguish it from the key identifier

@dmfalke dmfalke transferred this issue from VEuPathDB/EdaNewIssues Dec 9, 2022
@danicahelb
Copy link
Author

checked in with @dpbisme on 12/15/2022

  • mbio doesn’t care that sample IDs used on the website match sample IDs used by the original study team
  • we will use the same format for key identifiers for both mbio and ClinEpi, so we will not need a separate variable for “ClinEpiDB Sample ID”
  • SRA Sample ID can be useful to users, but we will remove this from appearing on the website & keep it in the download files (via hidden annotation)

@sweverschulman will work with @danicahelb to ensure this gets cleaned up properly

@danicahelb
Copy link
Author

much better now

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants