Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the PrometheusFilter to better account for handling unmatched requests #27

Open
dmgaldi opened this issue Dec 23, 2022 · 0 comments

Comments

@dmgaldi
Copy link
Contributor

dmgaldi commented Dec 23, 2022

Overview

Recently, unmatched requests were causing a null-pointer exception which was accounted for with a hot-fix here.

This is caused by the request filter not running for certain types of requests including 404 errors, though the response filter seems to run regardless. It may be worth taking some time to understand this interaction and update the code accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant