Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map - issues with barplot marker previews #326

Closed
bobular opened this issue Jun 27, 2023 · 1 comment · Fixed by #438
Closed

Map - issues with barplot marker previews #326

bobular opened this issue Jun 27, 2023 · 1 comment · Fixed by #438
Assignees
Labels
bug Something isn't working

Comments

@bobular
Copy link
Member

bobular commented Jun 27, 2023

Please check this is still a live issue after #190 is completed (and remove the question label).

Issue 1

The logscale mode for the preview bar marker doesn't seem to be right.

Here are no-logs markers - the preview looks similar to the three map markers:
image

Here are logged markers - now they don't look at all similar:
image

Originally posted by @bobular in #285 (comment)

Issue 2

The proportion mode is not working in the bar marker preview since the data for the marker preview is coming from the subsetting service, which does not support valueSpec: 'proportion'

@bobular bobular added bug Something isn't working question Further information is requested labels Jun 27, 2023
@bobular
Copy link
Member Author

bobular commented Aug 18, 2023

Still an issue. Making this required for beta

@bobular bobular removed the question Further information is requested label Aug 18, 2023
@jernestmyers jernestmyers self-assigned this Aug 21, 2023
@jernestmyers jernestmyers changed the title Map - logscale marker previews might not be right Map - issues with barplot marker previews Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants