Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDA viz tab: Export plot button does not export the legend #946

Open
danicahelb opened this issue Mar 11, 2024 · 3 comments
Open

EDA viz tab: Export plot button does not export the legend #946

danicahelb opened this issue Mar 11, 2024 · 3 comments
Assignees
Labels
bug Something isn't working UX Topic

Comments

@danicahelb
Copy link
Contributor

When you export a plot with an overlay, the legend should be included in the exported plot. Currently it is not, making the exported plot useless

@danicahelb danicahelb added the bug Something isn't working label Mar 11, 2024
@dmfalke
Copy link
Member

dmfalke commented Mar 19, 2024

This is not straightforward. One technical challenge is that the legend is not rendered as SVG, which I would consider a requirement for it being exported. Another is that the export button is part of the plot component, and does not know about the legend, so we might need to refactor things a little bit.

The other challenge is that we would have to decide how the legend is included in the export. Some options to consider are (in order from easy to hard):

  1. Offer a separate "export legend" option (it could be in the existing dropdown, or in a different button)
  2. Combine the plot and legend into a single SVG file
  3. Combine the plot and legend via a zip file

I think option 2 would be ideal, and I would estimate that would take 1-2 weeks.

@dmfalke dmfalke transferred this issue from VEuPathDB/EdaNewIssues Mar 19, 2024
@aurreco-uga aurreco-uga changed the title Export plot button does not export the legend EDA viz tab: Export plot button does not export the legend Apr 7, 2024
@jernestmyers
Copy link
Member

This came up in our ui-infra scrum and we decided this needs further discussion.

@bobular
Copy link
Member

bobular commented May 17, 2024

@steve-fischer-200 and @bobular suggest that ONE file is likely too much work

user will be editing the SVG anyway

So we provide two files: plot and legend

This assumes we can get SVG from our legend div relatively easily. (can we @dmfalke ?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UX Topic
Projects
None yet
Development

No branches or pull requests

5 participants