Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter pub upgrade --major-versions #17

Merged
merged 3 commits into from Apr 23, 2022

Conversation

domesticmouse
Copy link
Contributor

Description

Updating dependencies

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ› οΈ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • βœ… Build configuration change
  • πŸ“ Documentation
  • πŸ—‘οΈ Chore

@felangel
Copy link
Contributor

Thanks for the PR! Looks like the tests are failing. Let me know if you need help getting the ci to pass.

@domesticmouse
Copy link
Contributor Author

Thanks for the PR! Looks like the tests are failing. Let me know if you need help getting the ci to pass.

The tests are failing because the tests are pinned to run against Flutter 2.8.0, but this code has been updated to run correctly on Flutter 2.10.x. The tests are never going to pass until the test Flutter version unpin included in this PR is landed.

@felangel
Copy link
Contributor

Thanks for the PR! Looks like the tests are failing. Let me know if you need help getting the ci to pass.

The tests are failing because the tests are pinned to run against Flutter 2.8.0, but this code has been updated to run correctly on Flutter 2.10.x. The tests are never going to pass until the test Flutter version unpin included in this PR is landed.

I think 9add106 should resolve the issue. We just needed to also update the PR workflow in addition to the deploy workflow.

@domesticmouse
Copy link
Contributor Author

Please feel free to land at your convenience =)

@felangel felangel merged commit dbfb396 into VGVentures:release Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants