Move .env file to docker/.env #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subdavis
suggested changes
Sep 30, 2020
There was a problem hiding this comment.
This breaks LDC, pull latest kitware/ldc for support. FYI @BryonLewis
In order to support ldc from both / and /docker, could you add LDC_BASE_DIR=. to the environment file? No other change is necessary, I closed my other branch.
BryonLewis
approved these changes
Oct 1, 2020
subdavis
approved these changes
Oct 1, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #344
The reason the volume was failing to be removed was due to a mismatch between the a
.envfile in thedockerdirectory, and the source-controlled.envfile in the root directory. The deploy runs under thedockerdirectory, and so environment files pertaining to the docker stack should live in that directory. I believe it's best practice to keep these files at the same level as the compose file anyway.The only reason I could see to keep this file in the root directory would be to run girder/other parts of the stack locally. However that's not a use case we currently support/endorse, so I don't see a reason to keep the
.envfile in the root directory.