Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LGTM code quality badges #320

Closed
wants to merge 1 commit into from
Closed

Add LGTM code quality badges #320

wants to merge 1 commit into from

Conversation

xcorail
Copy link

@xcorail xcorail commented Sep 4, 2018

Hi there!

I thought you might be interested in adding these code quality badges to your project. They will indicate a very high code quality to potential users and contributors.
You can also check the alerts discovered by LGTM.

N.B.: I am on the team behind LGTM.com, I'd appreciate your feedback on this initiative, whether you're interested or not, if you find time to drop me a line. Thanks.

@remram44
Copy link
Member

remram44 commented Sep 4, 2018

I used landscape.io before but didn't particularly like it. I will give your service a try. Does it support C as well as Python? Is it ok with multiple languages in one repo?

@xcorail
Copy link
Author

xcorail commented Sep 4, 2018

Hello @remram44

Thanks for this feedback.

Yes we support C and C++: supported languages

If there are multiple languages in one repo, all of them are analysed: https://lgtm.com/help/lgtm/analysis-faqs#how-does-lgtm-determine-which-languages-to-analyze
If you have an example of repo where one language is missing, please point it to me ... it usually means that it has a complex build sequence and that our autobuilder didn't manage to compile it automagically.

While you're having a look at it, you should try out the PR integration, that you can activate easily here. This is the usage we recommend, as LGTM will report any new alert (or fix) directly within the GitHub pull request.

@remram44
Copy link
Member

remram44 commented Sep 4, 2018

This project has C code that doesn't seem to appear in LGTM (see LGTM vs GitHub). There is no "complex" build sequence, in the sense that it is a Python extension compiled the usual way using setuptools.

@remram44 remram44 added the T-housekeeping Type: Dealing with organization, services/hooks, running tests, packaging, ... label Sep 4, 2018
@xcorail
Copy link
Author

xcorail commented Sep 4, 2018

@remram44 let me check this! Thanks.

@xcorail
Copy link
Author

xcorail commented Sep 21, 2018

Hey @remram44

Just wanted to let you know that during 6 weeks, for each LGTM alert fixed, we'll make a donation to WWF. You can also win a free ticket to GitHub Universe, with travel and accommodation. Details here: https://competitions.lgtm.com/ghu-2018

@remram44
Copy link
Member

Aww but I already fixed them!

You seem to have fixed the C code not showing up, so I'll consider it.

@xcorail
Copy link
Author

xcorail commented Sep 21, 2018

Oh, sorry, I totally forgot to get back to you about the C code after making it work ...

@remram44 remram44 closed this Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-housekeeping Type: Dealing with organization, services/hooks, running tests, packaging, ...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants