Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactored unit test for conditioning #47

Merged
merged 1 commit into from
Feb 9, 2021
Merged

refactored unit test for conditioning #47

merged 1 commit into from
Feb 9, 2021

Conversation

psteinb
Copy link
Contributor

@psteinb psteinb commented Dec 9, 2020

  • replaced deprecated layer classes
  • made unit test CUDA/CPU aware (whatever is available)
  • refactored assertions
  • moved unit test input data into test case constructor
  • set manual seed to something != 0 to make tests reproducible
    • with seed=0, the test_jacobian gave errors sometimes and sometimes
    • I guess, randn calls yielded illconditioned jacobians

@psteinb
refactored unit test for conditioning
ad2f5a2 
- replaced deprecated layer classes
- made unit test CUDA/CPU aware (whatever is available)
- refactored assertions
- moved unit test input data into test case constructor
- set manual seed to something != 0 to make tests reproducible
  + with seed=0, the test_jacobian gave errors sometimes and sometimes
  + I guess, randn calls yielded illconditioned jacobians
@psteinb
Copy link
Contributor Author

psteinb commented Dec 9, 2020

@wapu @ardizzone I am using this framework everyday, so I'd like to contribute back. When used in this fashion, this test could now also be run on github actions or other platforms for CI.

@psteinb psteinb mentioned this pull request Feb 8, 2021
Open
@ardizzone ardizzone merged commit 3ee59e6 into vislearn:master Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@psteinb @ardizzone