Test toegevoegd voor vng-Realisatie/gemma-zaken#45 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
joeribekker
suggested changes
Aug 16, 2018
src/zrc/tests/test_userstory_45.py
Outdated
| 'zaak': zaak_url, | ||
| 'betrokkene': WATERNET, | ||
| 'betrokkeneType': RolTypes.organisatorische_eenheid, | ||
| 'rolomschrijving': RolOmschrijvingGeneriek.behandelaar, |
There was a problem hiding this comment.
Juist omdat het een test is, zou ik rolomschrijving een andere/custom waarde geven dan de generieke rol omschrijving.
joeribekker
approved these changes
Aug 16, 2018
src/openapi.yaml
Outdated
| @@ -115,21 +115,6 @@ paths: | |||
| - Initiator | |||
| - Klantcontacter | |||
| - Zaakcoördinator | |||
There was a problem hiding this comment.
"Mede-initiator" hier dan toevoegen?
Overigens net gelezen dat de enige case waarvoor dit geldt, is een huwelijk.
joeribekker
suggested changes
Aug 16, 2018
Per Slack discussie - hier is nog geen expliciete vraag om, en er is een voorstel tot wijziging in het RGBZ. Er leeft onduidelijkheid wat het verschil is met rolomschrijving.
sergei-maertens
force-pushed
the
feature/us-45-zet-behandelaar
branch
from
d4ca438
to
26429d0
Compare
|
@joeribekker feedback verwerkt |
joeribekker
approved these changes
Aug 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.