Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularized SimpleShaderInspector class #1

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Modularized SimpleShaderInspector class #1

merged 2 commits into from
Jan 29, 2021

Conversation

Cibbi
Copy link
Member

@Cibbi Cibbi commented Dec 25, 2020

This pr aims to separate behaviours currently happening inside the SimpleShaderInspector class.

In particular a lot of functions that are not required to be inside the SimpleShaderInspector class have been moved away, mainly to the SSIHelper class.

This makes possible to introduce a ISimpleShaderInspector interface that can be used whenever a user wants to make its own inspector without relying on the provided base class, but still having the ability to use single functions that were previously contained inside the SimpleShaderInspector class. Controls are now also able to access a ISimpleShaderInspector property that should contain the inspector they are displayed on, granted the inspector implementation takes care of setting that property in its controls during initialization.

This also needed a small rework of the localization system in order to make people able to use it in their own inspector implementations.

@Cibbi Cibbi added feature enhancement Change/update of a currently available feature v 0.2 goal Goal feature for v 0.2 release labels Dec 25, 2020
@Cibbi
Copy link
Member Author

Cibbi commented Dec 25, 2020

From some quick tests, these changes also improved inspector initialization time by around 30%, probably due to changes to the localization loading being less convoluted.

@Cibbi Cibbi merged commit b1b32f6 into master Jan 29, 2021
@Cibbi Cibbi deleted the development branch February 6, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature enhancement Change/update of a currently available feature v 0.2 goal Goal feature for v 0.2 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant