Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-c flag parameters for ETA mode #70

Closed
Senseikaii opened this issue Mar 20, 2021 · 3 comments
Closed

-c flag parameters for ETA mode #70

Senseikaii opened this issue Mar 20, 2021 · 3 comments

Comments

@Senseikaii
Copy link
Contributor

Senseikaii commented Mar 20, 2021

Hello,

I'm trying to launch VROOM in ETA mode but can't do it using vroom-express.
Do you have any recommendations on how I must launch it ?

@jcoupey
Copy link
Contributor

jcoupey commented Mar 21, 2021

You could simply add the -c flag to the command-line options passed to the system call (lookup reqOptions in file index.js). If you hard-code this, you won't be able to do regular requests any more though.

The best way to do it would be to allow overriding the -c flag on a per-request basis, exactly in the same way as with -g. A PR for this would actually be welcome.

@Senseikaii
Copy link
Contributor Author

Senseikaii commented Mar 21, 2021

Okay, that's what I though too. Will try to work on this.

#71

@jcoupey
Copy link
Contributor

jcoupey commented Apr 27, 2021

Done in #71.

@jcoupey jcoupey closed this as completed Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants