Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:set hlsearch? makes plugin freeze out #3344

Closed
g0sk0 opened this issue Jan 8, 2019 · 3 comments · Fixed by #3348
Closed

:set hlsearch? makes plugin freeze out #3344

g0sk0 opened this issue Jan 8, 2019 · 3 comments · Fixed by #3348
Labels

Comments

@g0sk0
Copy link

g0sk0 commented Jan 8, 2019

Queried the status of hlsearch.

To Reproduce

  1. type :set hlsearch?

Expected behavior
Expected to get an error message but I actually got a popup telling me hlsearch was disabled. Sadly the editor became unresponsive too, so I had to reload the plugin.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.01
  • VSCode version: 1.30.1
  • OS: Microsoft Windows 10 Pro version 1803
@xconverge
Copy link
Member

Are you using neovim integration by any chance?

@xconverge
Copy link
Member

FYI if you had clicked the little X on the popup, everything would have resumed with no problems :)

I still just moved the reporting of the query to the status bar anyways, since I didnt want to need to use my mouse to close the window (even if it didnt block), and this was simplest

@g0sk0
Copy link
Author

g0sk0 commented Jan 9, 2019

Excellent! Never ever hovered over those info popups before, didn't even know they were interactive. Also if for some reason you let it time out in cca 10s, you are stuck. As of the nvim integration: no, not using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants