Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yanking "clears" mode (or makes it disappear) from status bar until INSERT mode #3488

Closed
dstj opened this issue Feb 13, 2019 · 5 comments
Closed

Comments

@dstj
Copy link

dstj commented Feb 13, 2019

Issue Type: Bug

After yanking some text (a word, line, doesn't matter) from NORMAL mode, the mode disappears from the status bar at the bottom and won't reappear until we enter INSERT mode again. This makes recording macro quite annoying and error prone since we don't know what's going on.

To Reproduce

  1. qq
  2. y (mode disappears)
  3. p
  4. q (it won't show)
  5. i
  6. ESC
  7. q (now it shows).

Expected behavior
Step 5 and 6 shouldn't be necessary

ezgif com-video-to-gif

Extension version: 1.0.8
VS Code version: Code 1.31.1 (1b8e8302e405050205e69b59abb3559592bb9e60, 2019-02-12T02:20:54.427Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Xeon(R) CPU X5560 @ 2.80GHz (4 x 2793)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: unavailable_off
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 16.00GB (7.09GB free)
Process Argv
Screen Reader no
VM 50%
@jpoon
Copy link
Member

jpoon commented Feb 23, 2019

When you yank lines fewer than the config in vanilla vim, it actually shows nothing in the menu bar. ie, this behaviour is technically consistent with vanilla vim.

This extension is special however as we actually display --NORMAL-- mode when vim actually does not. So we can fix this by:

  1. updating the extension to NOT display --NORMAL-- when in NORMAL mode so we are consistent with VIM
  2. show correct mode after the yank.

@dstj
Copy link
Author

dstj commented Feb 23, 2019

I'd go for 2 then :).

Vanilla VIM's behavior is awkward and when recording a macro, it's confusing as hell :)

@lucasrrt
Copy link

Actually, the main problem here is that the Recording @q is disappearing when there is a yank/delete (some text manipulation). In vanilla vim, There is no --NORMAL-- message, but it's we can yank or delete without the Recording @q disappearing, as below:
Jul-24-2019 15-51-35

@J-Fields
Copy link
Member

J-Fields commented Aug 5, 2019

Related: #3838

@J-Fields
Copy link
Member

Closing in favor of #3838. I plan on doing a refactor of the status bar soon (it's rather janky), and will fix this in the process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants