Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim.searchHighlightColor does not work #3489

Closed
Praful opened this issue Feb 14, 2019 · 2 comments
Closed

vim.searchHighlightColor does not work #3489

Praful opened this issue Feb 14, 2019 · 2 comments

Comments

@Praful
Copy link

Praful commented Feb 14, 2019

Describe the bug

When I set this "vim.searchHighlightColor": "rgba(227, 122, 17, 0.8)", there is no change to the search highlight.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings
  2. Find the Vim:Search Highlight Color
  3. Change to rgba(227,122,17,0.8)
  4. Save settings.
  5. Open a file and search for a string using \find, where find is what you're searching for.
  6. There is no change in the highlight colour.

Expected behavior
The highlighted found word should be a different colour (the one specified) and not the default.

It would be even better if this extension used the system colours for highlighting search items: editor.findMatchBackground, editor.findMatchHighlightBackground and related options.

Screenshots
If applicable, add screenshots to help explain your problem.
If remapping-related, please attach log output: https://github.com/VSCodeVim/Vim#debugging-remappings.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.0.8
  • VSCode version: 1.31.1
  • OS: Windows 10 1809

Additional context
Add any other context about the problem here.

@RoyLee
Copy link

RoyLee commented Feb 20, 2019

I'm experiencing the same problem. I am on the mac OS and am on VSCode version 1.31.1, and VsCodeVim extension version 1.0.8. Thanks!

@jpoon
Copy link
Member

jpoon commented Feb 23, 2019

Since we moved to asynchronously loading the configuration, when this file is loaded the configurations will have their default values (https://github.com/VSCodeVim/Vim/blob/b4db97b6e3d2b910f664ab178cfb79167cb3f8e1/src/configuration/decoration.ts), as such, the configured values for the search highlight will never be reflected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants