Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim.statusBarColors.normal reports type error #3607

Closed
EntilZha opened this issue Mar 21, 2019 · 1 comment
Closed

vim.statusBarColors.normal reports type error #3607

EntilZha opened this issue Mar 21, 2019 · 1 comment

Comments

@EntilZha
Copy link

Describe the bug
The editor reports that the type of this setting is incorrect, expecting a string instead of array after setting things according to https://github.com/VSCodeVim/Vim#vim-airline

It looks like the type specification here is responsible https://github.com/VSCodeVim/Vim/blob/master/package.json#L579 but easily fixed.

To Reproduce
Steps to reproduce the behavior:

  1. Follow the instructions here https://github.com/VSCodeVim/Vim#vim-airline to enable color bars
  2. Let linters run
  3. Observe in the errors/warnings menu that VS code reports a type error in settings.json that the expected type is string

Expected behavior
There should not be a warning

Suggested Fix
My quickfix to see if my suspicion was correct was to edit ~/.vscode/extensions/vscodevim.vim-1.2.0/package.json to specify the type of that setting from "type": "string" to "type": ["string", "array"]. After reloading the editor this seems to have made the warning go away. A simple modification to the package.json I think fixes this.

Environment (please complete the following information):

better-toml bun 0.3.2
latex-workshop Jam 6.2.2
vscode-rust kal 0.4.2
python ms- 2019.2.5558
vscode-docker Pet 0.6.1
vim vsc 1.2.0
  • Extension (VsCodeVim) version: 1.2.0
  • VSCode version: 1.32.2
  • OS: Arch Linux
@EntilZha
Copy link
Author

If that fix seems reasonable I can open a PR, but for a one line fix, might be easier to have a committer make the minor change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants