Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jumping to a mark that is off-screen should center the view around the mark #3609

Closed
J-Fields opened this issue Mar 21, 2019 · 1 comment
Closed

Comments

@J-Fields
Copy link
Member

Describe the bug
Jumping to a mark from another part of the file should center the view around the mark (as if you did zz after the jump). Currently, the mark is brought just into view.

To Reproduce
Steps to reproduce the behavior:

  1. Place a mark with ma
  2. Scroll up (or down) far enough so that the mark is off screen
  3. Jump to the mark with 'a
  4. Observe that it is at the bottom (or top) of the view

Expected behavior
The view should be centered around the mark. Actually, vim seems to only do this when the mark is more than X (for some X I haven't bothered to figure out) lines out of view (or maybe away from current position). I'd be happy with a simple "out of view" check, though.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.2.0
  • VSCode version: 1.32.3
  • OS: Windows 10
@J-Fields
Copy link
Member Author

Seems this is a duplicate of #2960. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant