Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

catastrophic performance #3654

Closed
plbowers opened this issue Apr 5, 2019 · 6 comments
Closed

catastrophic performance #3654

plbowers opened this issue Apr 5, 2019 · 6 comments

Comments

@plbowers
Copy link

plbowers commented Apr 5, 2019

Issue Type: Bug

After a recent upgrade (both the vim emulator and the vscode editor, I believe) my performance has absolutely tanked.

I am waiting 10 and 20 seconds for the buffer to catch up to my keyboard buffer. Previous to this update I was typing naturally and never noticed any lag at all.

Steps to reproduce? Press i or cw or A or etc to go into editing mode and start typing.

Extension version: 1.3.0
VS Code version: Code 1.32.3 (a3db5be9b5c6ba46bb7555ec5d60178ecc2eaae4, 2019-03-14T23:43:35.476Z)
OS version: Windows_NT x64 10.0.17763

System Info
Item Value
CPUs Intel(R) Core(TM) i5-7300U CPU @ 2.60GHz (4 x 2712)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
surface_synchronization: enabled_on
video_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 7.93GB (1.04GB free)
Process Argv
Screen Reader no
VM 0%
@Hultner
Copy link

Hultner commented Apr 5, 2019

I just started using vscode (with vscvim) and I've noticed this as well. I was assuming that vscode/vscodevim was just this slow but maybe it's just this version? I've also noticed that the entire editor sometimes changes color theme back to the default dark one when I queue up to many actions in vim, especially when I use recordings.

@plbowers
Copy link
Author

plbowers commented Apr 6, 2019

I ran the process explorer and saw that my CPU usage went way high as soon as I tried to do anything in edit mode. I disabled the vim extension and the problem disappeared entirely.

I am attaching a profile
CPU-20190406T060715.189Z.cpuprofile.txt

@jpoon
Copy link
Member

jpoon commented Apr 8, 2019

#3662

@jpoon
Copy link
Member

jpoon commented Apr 8, 2019

The performance degradation in the 1.3.0 has been resolved in the latest revision with #3662. As such, im goign to close this out.

@Hultner
Copy link

Hultner commented Apr 10, 2019

@jpoon Thanks, I'm so happy that this was a bug and not actual expected performance :D

Huge thanks to you and the rest of the team behind VSCodeVim for the hard work making this a reality.

@jpoon
Copy link
Member

jpoon commented Apr 10, 2019

All credit goes to @ajalab on that one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants