Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vim.cursorStylePerMode is being ignored #4355

Closed
yujinyuz opened this issue Dec 10, 2019 · 1 comment · Fixed by #4468
Closed

vim.cursorStylePerMode is being ignored #4355

yujinyuz opened this issue Dec 10, 2019 · 1 comment · Fixed by #4468
Labels
kind/bug

Comments

@yujinyuz
Copy link

Describe the bug
In my settings.json I have these settings enabled:

"vim.cursorStylePerMode.insert": "underline",
"vim.cursorStylePerMode.normal": "underline",

To Reproduce
Steps to reproduce the behavior:

  1. Copy the settings and see that it's not working

Expected behavior
Should respect the settings.json file

Screenshots
If applicable, add screenshots to help explain your problem.
If remapping-related, please attach log output: https://github.com/VSCodeVim/Vim#debugging-remappings.

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.12.2
  • VSCode version: 1.40.2
  • OS: macOS

Additional context

It's working with 1.11.3 version
@yujinyuz yujinyuz changed the title Extension ignores custom settings Vim extension ignores settings.json Dec 10, 2019
@brennongs brennongs mentioned this issue Dec 10, 2019
Closed
@J-Fields J-Fields changed the title Vim extension ignores settings.json vim.cursorStylePerMode is being ignored Dec 10, 2019
@cvaldev
Copy link
Contributor

cvaldev commented Jan 2, 2020 •
edited

I found the source of this bug, It's being caused by configuration.getCursorStyleForMode() always returning undefined. I could send in a PR with a fix for it.

@cvaldev cvaldev mentioned this issue Jan 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix getCursorStyleForMode() always returned undefined cvaldev/Vim
3 participants
@yujinyuz @J-Fields @cvaldev