Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting vim.searchHighlightColor uses editor.findMatchHighlightBackground as default, but it is no longer available. #4369

Closed
nemeshnorbert opened this issue Dec 11, 2019 · 3 comments
Labels

Comments

@nemeshnorbert
Copy link

Describe the bug
Unable to write to User Settings because editor.findMatchHighlightBackground is not a registered configuration.

To Reproduce

  1. Run VS Code
  2. Open developer tools
  3. Behold

Expected behavior
No errors in the developer tools console.

Environment

  • Extension (VsCodeVim) version:
    1.12.2

  • VSCode version:
    Version: 1.40.2,
    Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
    Date: 2019-11-25T14:54:40.719Z
    Electron: 6.1.5
    Chrome: 76.0.3809.146
    Node.js: 12.4.0
    V8: 7.6.303.31-electron.0
    OS: Linux x64 5.0.0-37-generic

  • OS:
    Ubuntu 16.04.6 LTS

Additional context
My defualtSettings.json doesn't contain editor.findMatchHighlightBackground setting.

@J-Fields
Copy link
Member

We're accessing a theme color like configuration. We should be using that theme color as the default.

@macintacos
Copy link

Just a note: this doesn't seem to have been noted in the README (it still says that it's default is editor.findMatchHighlightBackground). Almost opened another issue for this 🙂

@J-Fields
Copy link
Member

@macintacos fixed, thanks for the heads up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants