Support for the preview Jupyter Notebook editor

[raghavmallampalli]

Describe the bug
The preview Jupyter Notebook editor now has extension support. VSCVim works out of the box. HOWEVER there are some issues I've encountered, such as Escape not allowing the user to browse the cells because of conflict with VSCVim shortcuts. I've started this thread so that people who wish to use VSCVim with the preview editor can report their issues so that the devs can get started on bug fixes or bypasses.

To Reproduce
Hit Escape while in normal mode of the preview editor and try to browse cells.

Expected behavior
Escape in insert mode goes to normal mode, Escape in normal mode allows exiting the cell editing environment into the cell browsing environment

Environment (please complete the following information):

• Extension (VsCodeVim) version: v1.17.0
• Version: 1.50.0-insider (user setup)
• OS: Windows_NT x64 10.0.19041

[coroa]

FWIW, you can configure it to behave correctly (ie. first Escape, leaves INSERT, second Escape leaves editor cell) by extending your keybindings.json (Command-Shift-P -> Open Keyboard Shortcuts (JSON)) to include

[

{
  "key": "escape",
  "command": "notebook.cell.quitEdit",
  "when": "inputFocus && notebookEditorFocused && !editorHasSelection && !editorHoverVisible && vim.active && vim.mode == 'Normal'"
},

]

Don't know, where to propose/include such a keybinding to have it shipped by VsCodeVim of the shelf.

[J-Fields]

I guess this is still only available in VSCode Insiders, unless I'm missing something?

[rebornix]

The notebook feature is the core part of VS Code so Vim extension would need to support that gracefully. I think it makes sense to have this keybinding in Vim. I'll make the change.

[ghost]

I guess this is still only available in VSCode Insiders, unless I'm missing something?

Yes it is only in the VS Code Insider. @coroa custom settings addition seems to be the only way. I just tried it with versus without.

[kamenbliznashki]

This appears to be an issue again after working for a little bit.

vscode insiders v 1.53 / 8490d3
vscodevim v1.18.8
jupyter v2020.12.414227025