va" and ya" includes spaces and tabs before quote

[boenshao]

Describe the bug
When quoted (" or ') content is prepended with spaces or tabs, visual select (va", va') and yank (ya", ya') would incorrectly includes the spaces or tabs.

To Reproduce
Steps to reproduce the behavior:

1. echo " \"quoted after spaces\"\n\t'quoted after tab'" > test.txt
2. code test.txt
3. navigate inside the quotes
4. va", va', ya" or ya'

Expected behavior
Visual select (or yank) the content (include the quotes), but exclude spaces or tabs before the quote.

Screenshots

• Extension (VsCodeVim) version: 1.21.3
• VSCode version: 1.57.1
• OS: macOS 11.4 and Ubuntu 20.10

[J-Fields]

Actually, this is expected behavior. From :help a":

Any trailing white space is included, unless there is none, then leading white space is included.

However, in Vim you can achieve the behavior you want by mapping a" to 2i" (and similar for the other quotes). We don't yet support this special case, but I've created #6806, which I'll try to get in the next release.

[jonboiser]

However, in Vim you can achieve the behavior you want by mapping a" to 2i"

This is what I did to get this working, if any one comes across this.

    "vim.visualModeKeyBindings": [
        {
            "before": ["a","\""],
            "after": ["2", "i", "\""]
        },
        {
            "before": ["a","'"],
            "after": ["2", "i", "'"]
        },
        {
            "before": ["a","`"],
            "after": ["2", "i", "`"]
        },
    ]

[laggardkernel]

That is how va" works

• https://vi.stackexchange.com/a/6144/20090
• Bug: Adding to a surround has weird spacing tpope/vim-surround#276

  "vim.visualModeKeyBindingsNonRecursive": [
    {
      "before": ["a","\""],
      "after": ["2", "i", "\""]
    },
    {
        "before": ["a","'"],
        "after": ["2", "i", "'"]
    },
    {
        "before": ["a","`"],
        "after": ["2", "i", "`"]
    },
  ].
  "vim.normalModeKeyBindings": [
    // https://github.com/tpope/vim-surround/issues/276. nmap but not nnoremap
    {
      "before": ["y", "s", "a","\""],
      "after": ["y", "s", "2", "i", "\""]
    },
    {
        "before": ["y", "s", "a","'"],
        "after": ["y", "s", "2", "i", "'"]
    },
    {
        "before": ["y", "s", "a","`"],
        "after": ["y", "s", "2", "i", "`"]
    },
  ],