Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting space as leader key does not work anymore #6824

Closed
fawni opened this issue Jul 3, 2021 · 6 comments
Closed

setting space as leader key does not work anymore #6824

fawni opened this issue Jul 3, 2021 · 6 comments

Comments

@fawni
Copy link

fawni commented Jul 3, 2021

Describe the bug
setting the leader key to " " does not work in version 1.21.4

To Reproduce
Steps to reproduce the behavior:

  1. set vim.leader to " "
  2. attempt to trigger leader key by pressing the spacebar
  3. leader key does not get triggered

Expected behavior
spacebar should trigger leader key

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.21.4
  • VSCode version: 1.57.1
  • OS: windows 10

Additional context
problem does not exist in version 1.21.3 or earlier

@OkkarMin
Copy link

OkkarMin commented Jul 4, 2021

Having the same issue here did 2 fresh reinstalls of VsCode. I probably should have checked issues first 🤦‍♂️

Environment (please complete the following information):

  • Extension (VsCodeVim) version: 1.21.4
  • VSCode version: 1.57.1
  • OS: MacOS BigSur 11.14

@nzig
Copy link

nzig commented Jul 4, 2021

Is this maybe the same as #6821? I initially thought my "space as leader" didn't work, but it turned out to be just easymotion that was broken. I've reverted to 1.21.3 for now.

@IsaacShelton
Copy link

IsaacShelton commented Jul 4, 2021

vim.leader doesn't seem to work anymore for me either in 1.21.4. When I roll back to 1.21.3 everything works as expected

I think it might have been broken in 7b3b17b

@marvdm
Copy link

marvdm commented Jul 6, 2021

Same here. I've had this issue before due to a conflict with something I already forgot — could be an extension or a setting, but I did not notice that an auto-upgrade occurred so I spent some time debugging until I gave up and decided to rollback one version (1.21.3) which finally did it for me.

@Howell5
Copy link

Howell5 commented Jul 6, 2021

vim.leader doesn't seem to work anymore for me either in 1.21.4. When I roll back to 1.21.3 everything works as expected

I think it might have been broken in 7b3b17b

True! rollback to 1.21.3 . the vim.leader: "<space>" worked well

Howell5 referenced this issue Jul 6, 2021
Only the left hand side should ever have "placeholder" keys like `<number>`
@J-Fields
Copy link
Member

J-Fields commented Jul 6, 2021

Sorry for the regression! This is fixed on 1.21.5, which is now available - please upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants