Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surround with HTML tags with attributes puts attributes in closing tag #7157

Open
Porges opened this issue Oct 15, 2021 · 1 comment
Open

Comments

@Porges
Copy link

Porges commented Oct 15, 2021

Describe the bug
It used to be that surrounding (e.g.) xyz with <a href="…"> would correctly generate <a href="…">xyz</a>, however this functionality seems to have been broken when surround started to use the top bar instead of the status bar (sorry, I don’t know what these are really called in VS Code terms).

To Reproduce

  1. insert the text xyz
  2. type viwS<a href="">, then Enter
  3. the editor reads <a href="">xyz</a href="">

Expected behavior

  1. insert the text xyz
  2. type viwS<a href="">, then Enter
  3. the editor reads <a href="">xyz</a>

Environment (please complete the following information):

Version: 1.61.0 (user setup)
Commit: ee8c7def80afc00dd6e593ef12f37756d8f504ea
Date: 2021-10-07T18:13:09.652Z
Electron: 13.5.1
Chrome: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Windows_NT x64 10.0.22471

VSCodeVim version: 1.21.8.

@Porges
Copy link
Author

Porges commented Oct 15, 2021

Another (small) thing is that “surround tag mode” used to be completed automatically when you typed >, but now you must push Enter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants