Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* does not reliably update search highlights #7462

Closed
J-Fields opened this issue Feb 7, 2022 · 2 comments
Closed

* does not reliably update search highlights #7462

J-Fields opened this issue Feb 7, 2022 · 2 comments

Comments

@J-Fields
Copy link
Member

J-Fields commented Feb 7, 2022

To reproduce:

  1. Search for something: /xyz<CR>
  2. Search for something else via *
  3. Notice xyz is still highlighted

This seem to be new in 1.22.0, possibly related to #7416 (pinging @adrsm108)

@J-Fields J-Fields added this to the Backlog milestone Feb 7, 2022
@J-Fields J-Fields changed the title * does not reliably update highlights * does not reliably update search highlights Feb 7, 2022
@adrsm108
Copy link
Contributor

adrsm108 commented Feb 7, 2022

I see this worked on my previous build, which was 48 commits behind master, so the bug must have been introduced fairly recently. I'll take a look.

Also notable: # doesn't seem to be working at all.

@J-Fields
Copy link
Member Author

J-Fields commented Feb 8, 2022

Testing the commit before yours, * was working (so it does seem the inccommand change broke it somehow), but # was broken. I've split that out into its own commit since it seems to be unrelated.

@J-Fields J-Fields modified the milestones: Backlog, On deck Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants