Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Experiments is enabled by default #145

Closed
1 of 2 tasks
ghost opened this issue May 3, 2019 · 9 comments
Closed
1 of 2 tasks

Enable Experiments is enabled by default #145

ghost opened this issue May 3, 2019 · 9 comments
Labels
discussion could go either way, discussion welcome

Comments

@ghost
Copy link

ghost commented May 3, 2019

Describe the bug
The setting Enable Experiments was enabled on a brand new clean install on Fedora 30.

Please confirm that this problem is VSCodium-specific

  • This bug doesn't happen if I use Microsoft's Visual Studio Code. It only happens in VSCodium.

Please confirm that the issue/resolution isn't already documented

To Reproduce
Steps to reproduce the behavior:

  1. On a Fedora 30 installation install VSCodium from the GitLab repo RPM
  2. Go to Settings
  3. Expand Workbench and check Enable Experiments and it will be checked

Expected behavior
This setting should be turned off as the description is:

Fetches experiments to run from a Microsoft online service.

Desktop (please complete the following information):

  • OS: Fedora 30
  • Architecture x64
  • Version 1.33.1
@ghost ghost added the bug Something isn't working label May 3, 2019
@stripedpajamas
Copy link
Member

Boooooooooooooo 👎

Good catch @evitalis, thank you for reporting this. It should be easy enough to default that to off since we already have the function to do so. I'll take care of it.

@ghost
Copy link
Author

ghost commented May 3, 2019

I also found the Natural Language setting is also on by default. Should I add that to a separate bug report?

@stripedpajamas
Copy link
Member

Well... currently there is this information in the doc: https://github.com/VSCodium/vscodium/blob/master/DOCS.md#getting-all-the-telemetry-out which acknowledges the NLP stuff and the other settings that call home to MS as something users could consider. Experiments might even fall into this category too as more of a user issue.

Microsoft is very clear in that they've tagged all of these with usesOnlineServices -- I'm wondering if the VSCodium contract of "disabling telemetry" covers other usesOnlineServices settings, and where exactly that line falls.

@stripedpajamas stripedpajamas added discussion could go either way, discussion welcome and removed bug Something isn't working labels May 3, 2019
@ghost
Copy link
Author

ghost commented May 4, 2019

For the discussion, would it be worth adding some other known (popular) extensions that send data to Microsoft? I know I use a Python extension I think is developed by them but seems the most maintained and popular. Not sure if it has telemetry in it.

@stripedpajamas
Copy link
Member

The question is whether or not VSCodium should disable all settings that "use online services" by default. These are:

  • Workbench: Enable Experiments
  • Workbench > Settings: Enable Natural Language Search
  • Update: Enable Windows Background Updates (this will probably need to be turned on when we get auto update support working)
  • Update: Show Release Notes
  • Extensions: Auto Check Updates
  • Extensions: Auto Update
  • Extensions: Show Recommendations Only On Demand (default off)
  • Telemetry: Enable Crash Reporter
  • Telemetry: Enable Telemetry

Currently, VSCodium disables the two Telemetry settings before building (https://github.com/VSCodium/vscodium/blob/master/update_settings.sh#L3-L4).

This issue was opened up regarding Enable Experiments. We need to figure out where the line is on setting the defaults for these settings.

(@evitalis -- the Python extension built by MS does send telemetry, but purportedly honors the Enable Telemetry settings flag -- see here)

@ghost
Copy link

ghost commented May 7, 2019

Why not just disable all of them?

@ghost
Copy link
Author

ghost commented May 20, 2019

@korlando7 Disabling everything may break some functionality so I think the team is trying to be cautious about that. Additionally some users may want some of the settings on, and while I prefer things to be opt-in not out, the world prefers the opposite.

@DavidOliver
Copy link

I would have thought that if someone has bothered to use an alternative to Microsoft's binaries they would be part of the prefer-opt-in camp.

@stripedpajamas
Copy link
Member

Thanks for the feedback, everyone. For now, VSCodium is going to remain true to what is said in the readme: "telemetry is disabled". The other options within VSCodium that use online services can be disabled as per the preference of the user.

The docs page makes it clear that there are options that connect to Microsoft's services and that they can all be disabled if desired.

In regard the original request: Enable Experiments does not call out to a Microsoft service if there is no experimentsUrl in the product.json file (see the code here). As VSCodium does not set the experimentsUrl at build time, the Enable Experiments option is irrelevant.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
discussion could go either way, discussion welcome
Projects
None yet
Development

No branches or pull requests

2 participants