Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHDL backend detection support for mcode JIT #1005

Merged
merged 1 commit into from Mar 20, 2024

Conversation

LukasVik
Copy link
Contributor

@LukasVik LukasVik commented Mar 19, 2024

Ongoing work on the GHDL master branch to use JIT makes VUnit backend detection fail. This makes all GitHub projects that use https://github.com/ghdl/setup-ghdl-ci with VUnit in their CI fail.

This commit adapts the regular expression so it works with newer as well as older GHDL versions with the mcode backend. As for the other backends, it looks like (ghdl/ghdl@4b20cd9#diff-0dc1fb1faeb66cc2780208579bbbe6a87011ad37a31f3d84dd64ff2224111fb6R530) they should all be affected by this change in the "ghdl --version" output. Or at least the LLVM backend?

I don't have access to GHDL built with GCC or LLVM, frankly I don't know how to build them. But I know that this PR fixes the issue for mcode. Perhaps there will be error reports or PRs from other people who use GCC/LLVM in the future.

@LukasVik LukasVik force-pushed the ghdl_mcode_jit branch 2 times, most recently from d1f3a0d to 98bc1b1 Compare March 19, 2024 10:52
@umarcor
Copy link
Member

umarcor commented Mar 19, 2024

@LukasVik, as far as I understand, this is just a change in a hardcoded string that is printed by ghdl version. That is, "mcode", "JIT", and "mcode JIT" are all the same, and they have been the same for years/decades. Precisely, mcode is an "in-memory just in time" backend, compared to LLVM/GCC which do not support JIT compilation/elaboration yet (although there is some related code in GHDL's repo because Tristan would like to eventually have LLVM JIT instead of the current compile & run execution model).
Therefore, the title, description and commit message of this PR are not correct. The issue is "updating the version/backend detection regular expression because the string changed upstream", but VUnit does already support "mcode JIT", support is not being added by this PR.

With regard to having this modification tested with other backends, do not worry about it because it's done in CI (at least LLVM). Since it's green, that means that your changes did not break anything.

@LukasVik LukasVik changed the title Add support for GHDL with mcode JIT backend Add GHDL backend detection support for mcode JIT Mar 20, 2024
@LukasVik
Copy link
Contributor Author

@umarcor Yes, when I wrote "add support" I was only referring to the backend detection regexp. I've updated the commit message and PR title to be more clear.

@eine eine added this to the v5.0.0 milestone Mar 20, 2024
@eine eine merged commit f38c1e3 into VUnit:master Mar 20, 2024
14 checks passed
@LukasVik LukasVik deleted the ghdl_mcode_jit branch March 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants