-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sim_if: continue after compilation failure if '--keep-compiling' is True #742
Conversation
38aaedd
to
c7cbac1
Compare
c7cbac1
to
297691a
Compare
297691a
to
39ed784
Compare
39ed784
to
2b4bb46
Compare
I haven't reviewed this yet but a gitter discussion reminded me that the compile error must never be forgotten. It should be seen in the test summary and the return code should not be zero |
@LarsAsplund the main purpose of this PR is to remove https://github.com/VHDL/Compliance-Tests/blob/master/run.py#L30-L69 by using |
I think that use case is perfectly valid but do you really want the default behavior for a failing compliance test to be return code = 0? |
Only in the cases when the user has explicitly set I would expect the exit code to be meaningful if we had some |
33eb0f1
to
7b74a29
Compare
7b74a29
to
5fc76c2
Compare
5fc76c2
to
bc06f92
Compare
bc06f92
to
212f9b3
Compare
ddf45a7
to
cc8c70d
Compare
cc8c70d
to
38e89c3
Compare
Currently, option
--keep-compiling
will raise an exception/error after all files are compiled. That is, it allows to continue while compilation failures are produced, but it does not allow to run the tests (those whose sources were successfully compiled, at least).This PR changes it, so that execution continues after compilation when
-k
is used.