Added support for detecting and failing on ambiguous direct entity instantiations. #781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsAsplund
force-pushed
the
err-on-ambiguous-entity-instantiations
branch
from
a6f4be6
to
d69e0e3
Compare
…stantiations. This happens when an entity has several architectures but the architecture is not specified in the instantiation. VHDL allows this and selects the last successfully compiled architecture. This can never be what the designer intended since she cannot fully control compile order.
LarsAsplund
force-pushed
the
err-on-ambiguous-entity-instantiations
branch
from
d69e0e3
to
ced027f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens when an entity has several architectures but the architecture
is not specified in the instantiation. VHDL allows this and selects the
last successfully compiled architecture. This can never be what the
designer intended since she cannot fully control compile order.