add flag fail_on_non_hdl_files to vivado.py #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smenzel, please check the format and linter errors. |
|
I fixed 3 of the linting issues, however, I don't know how to fix this problem without changing unrelated code that I don't understand fully: Also is it better to make a new commit for these review/linting changes or should I amend the previous commit (and force push in my branch) for a cleaner history? |
oscargus
reviewed
Nov 7, 2022
| @@ -13,11 +13,12 @@ | |||
| from pathlib import Path | |||
|
|
|||
|
|
|||
| def add_from_compile_order_file(vunit_obj, compile_order_file, dependency_scan_defaultlib=True): | |||
| def add_from_compile_order_file(vunit_obj, compile_order_file, dependency_scan_defaultlib=True, | |||
| fail_on_non_hdl_files=True): | |||
There was a problem hiding this comment.
Suggested change
| fail_on_non_hdl_files=True): | |
| fail_on_non_hdl_files=True): # pylint: disable=too-many-locals |
Should fix the pylint locals warning.
(I guess that in general, the fewer commits the better.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #782 as suggested by @LarsAsplund