Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No SystemVerilog support for add_from_compile_order_file in vivado.py #796

Open
o-uggla opened this issue Jan 17, 2022 · 0 comments · May be fixed by #871
Open

No SystemVerilog support for add_from_compile_order_file in vivado.py #796

o-uggla opened this issue Jan 17, 2022 · 0 comments · May be fixed by #871

Comments

@o-uggla
Copy link

o-uggla commented Jan 17, 2022

There is no support for SystemVerilog files when using the add_from_compile_order_file function. It currently only support VHDL, Verilog and Verilog Headers. Currently it fails on an assert if a SystemVerilog file type exist in the generated compile_order.txt file.

Support can be added by changing:

vunit/vivado/vivado.py

from:
30    with_dependency_scan = []
31    for library_name, file_name in compile_order:
32        is_verilog = file_name.endswith(".v") or file_name.endswith(".vp")

to:
30    with_dependency_scan = []
31    for library_name, file_name in compile_order:
32        is_verilog = file_name.endswith(".v") or file_name.endswith(".vp") or file_name.endswith(".sv")

and

vunit/vivado/vivado.py

from:
91        for line in ifile.readlines():
92            library_name, file_type, file_name = line.strip().split(",", 2)
93            assert file_type in ("Verilog", "VHDL", "Verilog Header")
94            libraries.add(library_name)

to:
91        for line in ifile.readlines():
92            library_name, file_type, file_name = line.strip().split(",", 2)
93            assert file_type in ("Verilog", "VHDL", "Verilog Header",  "SystemVerilog")
94            libraries.add(library_name)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants