Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated rivierapro.py as discussed in pull request #621 #825

Merged
merged 1 commit into from May 13, 2022

Conversation

dalex78
Copy link
Contributor

@dalex78 dalex78 commented May 10, 2022

Updated rivierapro.py as discussed in pull request #621

Note that the correction was originally found by OyvindNNL.

I do not have Riviera and cannot test this, but the fix was reviewed by @eine by 10 Feb 2020.

@umarcor
Copy link
Member

umarcor commented May 11, 2022

You can add Co-Authored-By: USER <name@email.com> to the commit message, so that git(hub) shows both users related to the commit. Alternatively, you can set @OyvindNNL as the author and you as the co-author.

@eine eine added this to the v4.7.0 milestone May 11, 2022
@dalex78 dalex78 changed the title Updated rivierapro.py as discussed in pull request #621 Updated rivierapro.py as discussed in pull request #621; Co-Authored-By: OyvindNNL May 11, 2022
@dalex78 dalex78 changed the title Updated rivierapro.py as discussed in pull request #621; Co-Authored-By: OyvindNNL Updated rivierapro.py as discussed in pull request #621 May 11, 2022
@dalex78
Copy link
Contributor Author

dalex78 commented May 11, 2022

Thank you umarcor, I'll check how to do that

@umarcor
Copy link
Member

umarcor commented May 11, 2022

git commit --amend --author 'Name of the author <author@email.com>'

or (if you want to set yourself as the author):

git commit --amend --reset-author

@LarsAsplund
Copy link
Collaborator

I have Riviera-PRO locally but couldn't really test this in a good way. If I start one simulator and set LICENSE_QUEUE in the console and then try to start another simulation it will wait even if I'm not using any of the global and uplevel approaches. I will revisit later to see if I can sort this out.

@dalex78
Copy link
Contributor Author

dalex78 commented May 12, 2022

Author is now @OyvindNNL.

@LarsAsplund LarsAsplund merged commit 78ef245 into VUnit:master May 13, 2022
@LarsAsplund
Copy link
Collaborator

Managed the verify this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants