Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSVVM: bump to 2022.04 #827

Merged
merged 1 commit into from
Jul 20, 2022
Merged

OSVVM: bump to 2022.04 #827

merged 1 commit into from
Jul 20, 2022

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented May 11, 2022

Based on #828.

This PR bumps the OSVVM submodule in VUnit.

@eine eine added Enhancement ThirdParty: OSVVM Related to OSVVM and/or OSVVMLibraries. Builtins labels May 11, 2022
@eine eine added this to the v4.7.0 milestone May 11, 2022
@umarcor umarcor changed the title OSVVM: bump to 2022.04 OSVVM: bump to 2022.03 May 11, 2022
@umarcor umarcor changed the title OSVVM: bump to 2022.03 OSVVM: bump to 2022.02 May 11, 2022
@umarcor umarcor force-pushed the bump-osvvm branch 3 times, most recently from 7130a84 to 8dff67b Compare May 11, 2022 22:43
@umarcor umarcor changed the title OSVVM: bump to 2022.02 OSVVM: bump to 2022.04 May 11, 2022
@umarcor umarcor marked this pull request as draft May 11, 2022 22:45
@umarcor umarcor marked this pull request as ready for review May 17, 2022 11:28
@eine eine merged commit 242e233 into VUnit:master Jul 20, 2022
@umarcor umarcor deleted the bump-osvvm branch July 20, 2022 12:13
@g0t00
Copy link

g0t00 commented May 22, 2023

@umarcor This is shown as being released as in 4.7.0 in the release notes.
If i manually checked out the v4.7.0 tag, It still seems to have the submodule set to 2021.12.
The same seems to be true for the released pip module.

@umarcor
Copy link
Member Author

umarcor commented May 22, 2023

@g0t00 you are correct. We unwantedly reverted it back to 2021.12 (04622a7#diff-8eabb1bbd50f80cf0a09c390b7f45cdd4564234e9a074a0e5178cb864ccc7692). I guess that @LarsAsplund had that version checked out locally and did commit -a without noting it.

I pushed an update to branch master and to branch v4.7. @g0t00, does that work for you or do you want us to push v4.7.1 to PyPI with this bugfix?

@g0t00
Copy link

g0t00 commented May 22, 2023

@umarcor Thanks a lot for the quick answer. I think thats fine, luckily pip can directly track git commits hashes, so this is pinned for now in our CI setup.

@umarcor
Copy link
Member Author

umarcor commented May 22, 2023

@g0t00 if you are using "git features" to pin requirements in pip, you might want to use https://github.com/VUnit/vunit/archive/master.zip (as in https://github.com/VHDL/Compliance-Tests/blob/main/requirements.txt) or https://github.com/VUnit/vunit/archive/v4.7.zip (which is a branch, not a tag, so it will move forward if more bugfixes are applied).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builtins Enhancement ThirdParty: OSVVM Related to OSVVM and/or OSVVMLibraries.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants