Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/installing/requirements/simulator: add NVC #914

Merged
merged 1 commit into from Apr 19, 2023

Conversation

umarcor
Copy link
Member

@umarcor umarcor commented Mar 5, 2023

This PR is based on #913.

Moreover, NVC 1.9 was not tagged yet (see #904 (comment)).

Therefore, this PR will be kept as a draft until #913 and NVC is tagged.

/cc @nickg

@umarcor umarcor marked this pull request as draft March 5, 2023 23:59
@umarcor umarcor changed the title docs/installing/requirements: add subsections docs/installing/requirements/simulator: add NVC Mar 5, 2023
@nickg
Copy link
Contributor

nickg commented Apr 7, 2023

I just published a 1.9 release here: https://github.com/nickg/nvc/releases/tag/r1.9.0

And I'm also running some VUnit test in the CI now to detect any future breakages: https://github.com/nickg/nvc/actions/runs/4636794223/jobs/8205178985

@umarcor
Copy link
Member Author

umarcor commented Apr 19, 2023

And I'm also running some VUnit test in the CI now to detect any future breakages: https://github.com/nickg/nvc/actions/runs/4636794223/jobs/8205178985

You might want to execute https://github.com/VUnit/vunit/blob/master/tests/acceptance/test_external_run_scripts.py through pytest, instead of manually running the examples. It will run a few more tests, but it will ensure tests are kept in sync with changes here thus slightly reducing your maintenance burden.

@umarcor umarcor marked this pull request as ready for review April 19, 2023 23:13
@eine eine added this to the v4.7.0 milestone Apr 19, 2023
@eine eine merged commit 4b363e9 into VUnit:master Apr 19, 2023
11 of 13 checks passed
@umarcor umarcor deleted the umarcor/docs/nvc branch April 19, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants