Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated common log interface. #947

Merged
merged 1 commit into from
Jul 15, 2023
Merged

Updated common log interface. #947

merged 1 commit into from
Jul 15, 2023

Conversation

LarsAsplund
Copy link
Collaborator

Update common log interface as outlined in OSVVM/OSVVM#80

@LarsAsplund LarsAsplund merged commit b69eac2 into master Jul 15, 2023
28 checks passed
@umarcor
Copy link
Member

umarcor commented Jul 17, 2023

@LarsAsplund please add a fragment to https://github.com/VUnit/vunit/tree/master/docs/news.d corresponding to this PR.

@eine eine added this to the v5.0.0 milestone Jul 17, 2023
@eine eine deleted the common_log_interface branch July 17, 2023 07:11
@LarsAsplund
Copy link
Collaborator Author

@umarcor Actually, it was already added with reference to #776. See https://github.com/VUnit/vunit/blob/master/docs/news.d/776.feature.rst

@umarcor
Copy link
Member

umarcor commented Jul 17, 2023

@LarsAsplund in those cases, just copy and paste the file with a different number in the filename but exactly the same content. See, for instance, e24d818 and http://vunit.github.io/release_notes.html#features.

I would like to contribute an enhancement to towncrier in order to handle these cases better. Yet, for now, this is the solution.

@LarsAsplund
Copy link
Collaborator Author

@umarcor Will do.

@LarsAsplund
Copy link
Collaborator Author

@umarcor Hm, my latest push with common log updates came with its own branch/PR. Should that have generated yet another news item?

@umarcor
Copy link
Member

umarcor commented Jul 17, 2023

@LarsAsplund yes. in the end, we want all the issues/PRs related to this change/item/feature to show as a single list in http://vunit.github.io/release_notes.html#features.
However, if you are going to push a docs/news.d: cp 776 949 or docs/news.d: cp 947 949 only, do push that to master straightaway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants