Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim_if/nvc.py: add a new nvc.global_flags option #948

Merged
merged 1 commit into from
Jul 17, 2023

Conversation

nickg
Copy link
Contributor

@nickg nickg commented Jul 16, 2023

This can be set for compilation/simulation to pass additional global arguments to the nvc command. See issue #946.

This can be set for compilation/simulation to pass additional global
arguments to the nvc command. See issue VUnit#946.
@@ -27,6 +27,14 @@ The following compilation options are known.
Extra arguments passed to ModelSim ``vlog`` command when compiling Verilog files.
Must be a list of strings.

``nvc.a_flags``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might we worth adding a "Global Options" or "Common Options" section, either at the beginning or the end of the page? Rather than repeating the nvc.global_args in both sections.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. It's actually two different options with the same name. Users might want to set "global sim options" but not "global elaboration options", or the other way round.
Therefore, it's good as is.

@eine eine added this to the v5.0.0 milestone Jul 17, 2023
@eine eine merged commit af76f42 into VUnit:master Jul 17, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants