Add edit id for commands #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aafanasev
reviewed
Jun 2, 2020
| val language: String by option("--language", "-l", help = "The language code (a BCP-47 language tag) of the localized listing to read or modify. For example, to select Latin American Spanish, pass \"es-419\".").required() | ||
|
|
||
| override fun run(api: PlayStoreApi) = api.listingsGet(ListingsGetModel(packageName, language)) | ||
| override fun run(api: PlayStoreApi) = api.listingsList(EditModel(packageName, editId)) |
There was a problem hiding this comment.
language variable is not used, is it intentional?
| class DeleteAll : EditCommand(name = "deleteAll", actionDescription = "Deletes all localized listings from an edit") { | ||
| val language: String by option("--language", "-l", help = "The language code (a BCP-47 language tag) of the localized listing to read or modify. For example, to select Latin American Spanish, pass \"es-419\".").required() | ||
|
|
||
| override fun run(api: PlayStoreApi) = api.listingsDeleteAll(EditModel(packageName, editId)) |
There was a problem hiding this comment.
language variable is not used, is it intentional?
|
|
||
| val track = Track().setReleases(listOf(release)) | ||
|
|
||
| return edits.tracks().update(model.packageName, model.editId, model.track, track).execute() |
There was a problem hiding this comment.
shouldn't this have the same logic as others model.editId ?: edits.insert(model.packageName, null).execute()? as I see TracksUpdateModel#editId is nullable
|
@aafanasev thanks for the review |
aafanasev
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
For example we want to upload APK to
internaltesting channel. We should do it in the same transaction (edit id). Unfortunately we can't upload it to any channel without this chain. Also any transaction should be committed.