Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with Erlang/OTP-22 socket module #168

Closed
dmorneau opened this issue Apr 2, 2019 · 10 comments · Fixed by #169
Closed

Conflict with Erlang/OTP-22 socket module #168

dmorneau opened this issue Apr 2, 2019 · 10 comments · Fixed by #169
Assignees

Comments

@dmorneau
Copy link

dmorneau commented Apr 2, 2019

Erlang/OTP-22 is introducing a new module called "socket", documented here (as of 22-rc2):

http://erlang.org/documentation/doc-11.0-rc2/erts-10.4/doc/html/socket.html

This module conflicts with the module called "socket" in gen_smtp, preventing us from using the library when running on 22-rc2 (undefined function error for socket:connect/5). Would it be possible to rename the module to something like "gen_smtp_socket" perhaps?

@Vagabond
Copy link
Collaborator

Vagabond commented Apr 2, 2019

Yeah. I don't know when I'll get around to it though, so if you wanted to make a PR that'd make it go faster.

@mworrell mworrell self-assigned this Apr 3, 2019
@mworrell
Copy link
Collaborator

mworrell commented Apr 3, 2019

I will have a go at it.

@mworrell
Copy link
Collaborator

mworrell commented Apr 3, 2019

Added a merge request in #169

@dmorneau
Copy link
Author

dmorneau commented Apr 4, 2019

Fantastic, thank you!

@mworrell
Copy link
Collaborator

mworrell commented Apr 5, 2019

@dmorneau Thanks for reporting the issue!

@dmorneau
Copy link
Author

Hello! @Vagabond would it be possible to push a release to hex now that OTP-22 is out?

@ckruse
Copy link

ckruse commented May 21, 2019

Releasing a new version because of this would be pretty nice, yes.

@mworrell
Copy link
Collaborator

If @Vagabond doesn't have time, then @arjan can you have a look at making a new release and pushing it to Hex?

@arjan
Copy link
Collaborator

arjan commented May 21, 2019

on it!

@arjan
Copy link
Collaborator

arjan commented May 21, 2019

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants