New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dkim signing for outgoing emails #49
Conversation
This is useful for, eg, when attachement filenames are not in ASCII encoding
May handle broken emails, which contains splitted not by characters, but by bytes multibyte strings.
Conflicts: src/mimemail.erl
Conflicts: src/mimemail.erl
This was needed for DKIM signing of headers, containing ";". Also, minor performance improevement, because of no '++' operations.
So, 2 weeks in production - DKIM works with no issues. |
I'd like to see this go in, although I'm short on review time right now, and there's a lot to digest here. |
Looks like quite some commits are actually coming from the master. The DKIM commits are not so many. @seriyps any commits we need to look at specifically? |
@mworrell yeah, as I noted, some of commits in this branch are not relevant to DKIM, they appears in this pull-request, because I've implemented DKIM on top of my fork, but not directly from upstream. But I don't know how to separate them from this branch. I think, if I make another pull-request of my master branch, which include only not-yet-merged improvements of MIME-parser, DKIM patch will become much smaller. |
replaced by #57 |
Actualy, added support for DKIM signing in mimemail module.
Unfortunately, this patch also include not-yet-merged part from issue #36 (permissive headers parser), but it may be merged separately, from my master branch.
Tests included, as well as documentation (in README).
I have this code in production server for about 2 days (2 days with simple canonicalization and ~2 hrs with just implemented relaxed canonicalization algorithms) with 0 problems: google and other mail services accept this signature:
P.S.: this DKIM stuff may be implemented in separate module, because it uses only few functions from
mimemail
, so, this is a subject for discussion.