Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wish add realesrgan-ncnn-vulkan model in the app #2

Closed
ghost opened this issue Mar 13, 2022 · 9 comments
Closed

wish add realesrgan-ncnn-vulkan model in the app #2

ghost opened this issue Mar 13, 2022 · 9 comments

Comments

@ghost
Copy link

ghost commented Mar 13, 2022

wish add realesrgan-ncnn-vulkan model in the app

@Vaida12345
Copy link
Owner

Thank you for your advice, It has been added, please download the latest version from releases
Please inform me if you encounter any bug.

@ghost
Copy link
Author

ghost commented Mar 15, 2022

Thank you very much for your reply, but there may be some misunderstandings. I hope you can add the following model to the app instead of RealSR one.

https://github.com/xinntao/Real-ESRGAN

This app is the most beautiful and useful of the open source and non open source software for macOS I found on the Internet. Thank you very much for your outstanding work, whether you add the above model or not.

@ghost
Copy link
Author

ghost commented Mar 15, 2022

By the way, I tested RealSR and Real-ESRGAN with the binary unix app of the open source project. Real-ESRGAN has better performance in the magnification effect of animation images, far way better. That's why I hope you can adopt Real-ESRGAN.
The following is the original picture:
f43b4bc630461764aa4ff030c709a468

The following is a 4x scale magnification comparison of RealSR(left) and Real-ESRGAN(right) by Kaleidoscope.app:
compare

@Vaida12345
Copy link
Owner

Working on that, thank you for your suggestions.

@Vaida12345
Copy link
Owner

@ghost
Copy link
Author

ghost commented Mar 16, 2022

The new release comes too fast. Thank you very much for your incredible work!
The app size is quite large but this won't be a problem to me. The function of the app has been greatly improved, and the interactive design is also very intuitive and easy to use.
As far as I know, this app is the only macOS app supporting Real-ESRGAN model and written in Swifty language,that can be found on the Internet at present. The actual test results are outstanding. It's really great!
Wow it supports animation video too!?My Macbook is made of Intel chip. It takes several hours to process a video. I'm so curious about how long it will take Apple M1 chip to process a 200 megabyte video?

@Vaida12345
Copy link
Owner

If you use waifs2x_Caffe, it would be pretty fast, my M1Max took only ~0.7s to process a 1080p image. But other models are quite slow, as I just used their complied executable file, which do not use the Apple Neural Engine.

@Vaida12345
Copy link
Owner

Thank you for using this app!

@ghost
Copy link
Author

ghost commented Mar 17, 2022

I recommended your open source projects in the excellent software discussion forum I often go to. Your excellent works should be known by more people, especially on the isolated island of MacOS. Thank you for creating the outstanding app for macOS, it really helps!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant