Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate parsing from sockets #50

Open
KOLANICH opened this issue Apr 15, 2022 · 1 comment
Open

Separate parsing from sockets #50

KOLANICH opened this issue Apr 15, 2022 · 1 comment

Comments

@KOLANICH
Copy link

I have some packets as bytes and want to analyse them. I also want to generate them as bytes. Currently it is done within the classes for sockets, but they are tied to network functions.

It is proposed to move the parsing and serialization code into .models and add the 2 methods, __bytes__ and from_bytes.

@ValentinBELYN
Copy link
Owner

Hi @KOLANICH!

You are right. I have already thought about it several times but until now, the fact of putting the logic at the level of the sockets allowed me to multualize certain variables and portions of code.

I'll try to change that as part of the next major update. However, I have a lot of projects to finish before :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants