Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@slidy/svelte - first render in firefox #73

Closed
Valexr opened this issue May 11, 2022 · 1 comment
Closed

@slidy/svelte - first render in firefox #73

Valexr opened this issue May 11, 2022 · 1 comment
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@Valexr
Copy link
Owner

Valexr commented May 11, 2022

This seems to happen because: the list items do not receive the size of the images, and after the images are loaded, they are expanded to their size. @slidy/core also doesn't get the size of the target node's childs and spins what has arrived.

Just compare how it works in vanilla.
Even width: auto handles child sizes correctly as well.

Maybe the rules in CSS are missing some...🤷🏻‍♂️

@Valexr Valexr added bug Something isn't working enhancement New feature or request labels May 11, 2022
@EricRovell
Copy link
Collaborator

b242277 fixes the bug. The problem was in .slidy-slides styles: justify-content was set for thumbs, it breaks the sizing of the slides. That was done some time ago to position the thumb at center when the edges of the carousel was moving too much apart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants