Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not supported Sega CD PCM sounds? #99

Open
vitamin-caig opened this issue May 23, 2022 · 7 comments
Open

Not supported Sega CD PCM sounds? #99

vitamin-caig opened this issue May 23, 2022 · 7 comments

Comments

@vitamin-caig
Copy link
Contributor

Hello!

Found out that Sega CD tracks sound improperly. Please check out https://vgmrips.net/packs/pack/silpheed-mega-cd

Checked also at the most recent version 8dcffa4

@ValleyBell
Copy link
Owner

ValleyBell commented May 23, 2022

What tracks sound incorrect and in which way? (specific songs would be nice and timestamps would be even nicer)

I listenened to a few of them using the current libvgm player and also vgmplay-libvgm and didn't notice anything that is obviously wrong.

@vitamin-caig
Copy link
Contributor Author

Right first one "01 - IPL ~ Opening Demo.vgz" produces no sound. Maybe, I've missed some devices definitions?

@ValleyBell
Copy link
Owner

You need to enable "RF5C68: Gens core" for MegaCD PCM.
Due to historic reasons, RF5C68 MAME is used for the "RF5C68" from the VGM spec. and RF5C68 Gens is used for the "RF5C164".

I should probably relax that requirement.

@vitamin-caig
Copy link
Contributor Author

Both RF5C68 cores were used. I've disabled SNDDEV_SELECT (adding all necessary files to linkage) and tracks are working.

Looks like it's required to support minimal essential cores set to avoid linking redundant code.

@vitamin-caig
Copy link
Contributor Author

Closing as invalid:)

@ValleyBell
Copy link
Owner

Well... I think it's not entirely invalid.
Requireing both cores for everything to work is effectively undocumented behaviour.

I'll keep it open as long as this requirement is in place.

@mmontag
Copy link

mmontag commented Dec 13, 2023

This helped me fix a similar issue in Chip Player JS. Thanks @vitamin-caig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants