[READY] Catch CalledProcessError exception in install script #2405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exception is not relevant to the install failure. Catch it and exit with the status code returned by the build script.
Current coverage is 81.09% (diff: 100%)@@ master #2405 diff @@
==========================================
Files 17 17
Lines 1873 1873
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1519 1519
Misses 354 354
Partials 0 0
|
|
Thanks! Unfortunate that the original PR author gave up... Review status: 0 of 1 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
Reviewed 1 of 1 files at r1. Comments from Reviewable |
|
📌 Commit 7b251db has been approved by |
homu
added a commit
that referenced
this pull request
Oct 25, 2016
[READY] Catch CalledProcessError exception in install script See PR ycm-core/ycmd#630. Closes #2351. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/youcompleteme/2405) <!-- Reviewable:end -->
|
☀️ Test successful - status |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR ycm-core/ycmd#630.
Closes #2351.
This change is