Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Convert update_boost script to Python #516

Merged
merged 1 commit into from
Jun 6, 2016

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Jun 6, 2016

While trying to fix the build issue on Windows in PR #490, I decided to port the update_boost shell script to Python so that it can be executed on Windows. In addition to being more portable, the script now automatically downloads the latest Boost archive and extracts it.

The script contains the necessary change (removing the xml_woarchive.cpp file) to fix the errors when updating Boost to 1.61.0 and compiling on Windows (with MSVC). We don't remove anymore the shared_ptr_helper.cpp file since it is not included with latest Boost.

I am marking this PR as RFC since you may consider it not worth merging. Whether it is merged or not, I will send a PR that updates Boost to 1.61.0 (using this script of course).


This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.978% when pulling 9e78fb5 on micbou:update-boost into 47304e1 on Valloric:master.

@Valloric
Copy link
Member

Valloric commented Jun 6, 2016

The less shell we have, the better off everything is. So a big 👍 from me.

The only thing that bothers me a little is that there's way more python code than shell code, but I'll take 10 lines of python over one line of shell, so still good.

@Valloric
Copy link
Member

Valloric commented Jun 6, 2016

:lgtm:

Previously, Valloric (Val Markovic) wrote…

The less shell we have, the better off everything is. So a big 👍 from me.

The only thing that bothers me a little is that there's way more python code than shell code, but I'll take 10 lines of python over one line of shell, so still good.


Review status: 0 of 2 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@vheon
Copy link
Contributor

vheon commented Jun 6, 2016

:lgtm: @homu r=Valloric

Previously, Valloric (Val Markovic) wrote…

:lgtm:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@homu
Copy link
Contributor

homu commented Jun 6, 2016

📌 Commit 9e78fb5 has been approved by Valloric

@homu
Copy link
Contributor

homu commented Jun 6, 2016

⚡ Test exempted - status

@homu homu merged commit 9e78fb5 into ycm-core:master Jun 6, 2016
homu added a commit that referenced this pull request Jun 6, 2016
[RFC] Convert update_boost script to Python

While trying to fix the build issue on Windows in PR #490, I decided to port the `update_boost` shell script to Python so that it can be executed on Windows. In addition to being more portable, the script now automatically downloads the latest Boost archive and extracts it.

The script contains the necessary change (removing the `xml_woarchive.cpp` file) to fix the errors when updating Boost to 1.61.0 and compiling on Windows (with MSVC). We don't remove anymore the `shared_ptr_helper.cpp` file since it is not included with latest Boost.

I am marking this PR as RFC since you may consider it not worth merging. Whether it is merged or not, I will send a PR that updates Boost to 1.61.0 (using this script of course).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/516)
<!-- Reviewable:end -->
@micbou micbou deleted the update-boost branch June 7, 2016 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants