[READY] Use equality instead of identity when checking the status response in Rust completer #521
Conversation
Check that no error is raised and completions are empty when racerd returns a no content response.
I agree with this. Reviewed 2 of 2 files at r1. Comments from Reviewable |
|
Either edit the commit message to close #520 or remember to close it by hand 😃 |
|
Unfortunately, it doesn't fix the issue. In #520, racerd is crashing instead of returning a 204 no content response.
|
The user that opened the bug said that racerd didn't crash so I assumed that this was going to fix the bug on our hand but I should've read more carefully 😒 Review status: all files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
|
The real problem here was the lack of test coverage for the NO_CONTENT branch. Thanks for fixing this!
|
|
@homu r+ @Valloric You didn't give your opinion about using
|
all files reviewed at latest revision, all discussions resolved, all commit checks successful.
|
📌 Commit e681335 has been approved by |
|
⚡ Test exempted - status |
…=micbou [READY] Use equality instead of identity when checking the status response in Rust completer `http.client.NO_CONTENT` is an enumeration member while `response.status_code` is an int so we need to use an equality instead of an identity. Added a test for when racerd returns a no content response. On a side note, I think we should use [`requests.codes` instead of `http.client`](http://docs.python-requests.org/en/master/user/quickstart/?highlight=status_code#response-status-codes) in these situations. This would prevent this kind of issue (`requests.codes.no_content` is an int) and we would not have to import the `http.client` module. If you agree, I'll send a PR replacing all `http.client` occurences. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/521) <!-- Reviewable:end -->
Sorry, missed that. I'm fine with it. |
http.client.NO_CONTENTis an enumeration member whileresponse.status_codeis an int so we need to use an equality instead of an identity.Added a test for when racerd returns a no content response.
On a side note, I think we should use
requests.codesinstead ofhttp.clientin these situations. This would prevent this kind of issue (requests.codes.no_contentis an int) and we would not have to import thehttp.clientmodule. If you agree, I'll send a PR replacing allhttp.clientoccurences.This change is