Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[READY] Use HTTP status codes from requests module instead of http one #523

Merged
merged 1 commit into from
Jun 12, 2016
Merged

[READY] Use HTTP status codes from requests module instead of http one #523

merged 1 commit into from
Jun 12, 2016

Conversation

micbou
Copy link
Collaborator

@micbou micbou commented Jun 11, 2016 •
edited by Valloric
Loading

See the requests documentation.

This change is Reviewable

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.008%) to 85.073% when pulling 0f738de on micbou:requests-status-code into 89a6afb on Valloric:master.

@vheon
Copy link
Contributor

vheon commented Jun 11, 2016

:lgtm:

Previously, coveralls wrote…

Coverage Status

Coverage decreased (-0.008%) to 85.073% when pulling 0f738de on micbou:requests-status-code into 89a6afb on Valloric:master.

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@Valloric
Copy link
Member

Nice, thanks!

@homu r=vheon

Previously, vheon (Andrea Cedraro) wrote…

:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

@homu
Copy link
Contributor

homu commented Jun 12, 2016

📌 Commit 0f738de has been approved by vheon

@homu
Copy link
Contributor

homu commented Jun 12, 2016

⚡ Test exempted - status

@homu homu merged commit 0f738de into ycm-core:master Jun 12, 2016
homu added a commit that referenced this pull request Jun 12, 2016
@homu
Auto merge of #523 - micbou:requests-status-code, r=vheon
b7484df 
[READY] Use HTTP status codes from requests module instead of http one

See [the requests documentation](http://docs.python-requests.org/en/master/user/quickstart/?highlight=status_code#response-status-codes).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/523)
<!-- Reviewable:end -->
@micbou micbou deleted the requests-status-code branch June 12, 2016 22:21
@micbou micbou mentioned this pull request Jun 26, 2016
Merged
homu added a commit that referenced this pull request Jun 26, 2016
@homu
Auto merge of #531 - micbou:requests-status-code, r=vheon
bb0f422 
[READY] Use status code from requests instead of http.client in Rust test

See PR #523.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/valloric/ycmd/531)
<!-- Reviewable:end -->
@micbou micbou mentioned this pull request Jul 14, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@micbou @coveralls @vheon @Valloric @homu